[Stgt-devel] [PATCH] add stgt_device_template example

[Mike Christie]

FUJITA Tomonori wrote:
> From: FUJITA Tomonori <tomof at acm.org>
> Subject: Re: [Stgt-devel] [PATCH] add stgt_device_template example
> Date: Tue, 23 Aug 2005 23:51:26 +0900
> 
> 
>>>This adds the beginings of a stgt_device_template for
>>>passthrough commands. It will end up using the block
>>>layer BLOCK_PC facility to pass the command to the
>>>underlying device similar to how we do it for SG_IO
>>>and dm-multipath hw_handlers like dm-emc.c.
>>>
>>>It is not completely hooked in yet. The command
>>>handling needs to be done and so does the actual
>>>device creation.
>>
>>Great! 
>>
>>Here are small fixes.
> 
> 
> Forgot to mention.
> 
> Do we need to use GFP_ATOMIC instead of GFP_KERNEL in
> stgt_device_create()?

I do not think so. It does not seem like we will be in
interrupt context and it does not look like we
are under a spin_lock. Was there something else
you were thinking of (probably was :))?