[Stgt-devel] [PATCH 1/2] fix task leaks on conn close

Mike Christie michaelc
Wed Oct 4 07:38:31 CEST 2006


The attached patch adds a connection refcount and forces the cleanup of
pending tasks or tasks that are not going to get completed by are not
running in tgtd. The refcout is needed for the latter. When those
commands have completed we then release the connection.

This patch only handles the memory issues. Should we actually not close
the connection endpoints and should we send the result of the commands
that were executing in tgtd when they finally complete? For some like
linux-iscsi or open-iscsi, when the connection is dropped we assume the
command is not executed, but tgtd might actually complete it. Is either
wrong?

I will send a seperate patch to fix the command completeion issue above
and the session leak.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01-add-refcount-to-conn.patch
Type: text/x-patch
Size: 10123 bytes
Desc: not available
Url : https://lists.berlios.de/pipermail/stgt-devel/attachments/20061004/76c487d2/attachment.bin 



More information about the stgt mailing list