[Stgt-devel] vtl patch.

[FUJITA Tomonori]

From: "Mark Harvey" <markh794 at gmail.com>
Subject: Re: [Stgt-devel] vtl patch.
Date: Thu, 5 Apr 2007 13:05:45 +1000

> Re-sending updated ssc3.c & smc.c in full.

Thanks. I'll review and merge the patch soon.


> Includes first couple of "improvements" pointed out by Ming.
>  - memory leak fixed.
>  - case insensitive compare.
> 
> The 3rd one (referenced below), I shall look at later on today.

I like the current approach.


> Cheers
> Mark Harvey
> 
> 
> On 4/5/07, Mark Harvey <markh794 at gmail.com> wrote:
> > On 4/5/07, Ming Zhang <blackmagic02881 at gmail.com> wrote:
> > >
> > > On Thu, 2007-04-05 at 09:56 +1000, Mark Harvey wrote:
> > > > +       .ops    = {
> > > > +               {spc_test_unit,},
> > > > +               {spc_illegal_op,},
> > > > +               {spc_illegal_op,},
> > > > +               {spc_request_sense,},
> > > > +               {spc_illegal_op,},
> > > > +               {spc_illegal_op,},
> > > > +               {spc_illegal_op,},
> > > > +               {spc_illegal_op,},
> > > > +
> > > > +               {spc_illegal_op,},
> > > > +               {spc_illegal_op,},
> > > > +               {spc_illegal_op,},
> > >
> > > instead of having tons of these spc_illegal_op, can we have them by
> > > default to be NULL and the caller check if NULL, if NULL call
> > > spc_illegal_op directly?
> > >
> >
> > I basically copied the sbc.c module and followed its syntax, and
> > called/set all un-implemented routines to spc_illegal_op for the time
> > being.
> >
> > But I like your suggestion.
> >
> > Cheers
> > Mark
> >