Compare err itself to zero, not the pointer. Found by Bart Van Assche. Signed-off-by: Pete Wyckoff <pw at osc.edu> --- usr/mgmt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/usr/mgmt.c b/usr/mgmt.c index 287c03c..041f0ff 100644 --- a/usr/mgmt.c +++ b/usr/mgmt.c @@ -60,7 +60,7 @@ struct mgmt_task { static void set_show_results(struct tgtadm_rsp *rsp, int *err) { - if (err < 0) + if (*err < 0) rsp->err = *err; else { rsp->err = 0; -- 1.5.3.6 |