[Stgt-devel] [PATCH] one more iscsi ahs bug fix

Pete Wyckoff pw
Fri Mar 16 21:13:45 CET 2007


Try to fix the precedence bug again.  Binary + really does happen
before ternary ? : .

Signed-off-by: Pete Wyckoff <pw at osc.edu>
---

 usr/iscsi/iscsid.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/usr/iscsi/iscsid.c b/usr/iscsi/iscsid.c
index 6fd469d..131c838 100644
--- a/usr/iscsi/iscsid.c
+++ b/usr/iscsi/iscsid.c
@@ -1241,7 +1241,7 @@ static int iscsi_scsi_cmd_rx_start(struct iscsi_connection *conn)
 		req->flags & ISCSI_FLAG_CMD_ATTR_MASK, req->itt);
 
 	task_len = max(imm_len, data_len) +
-		ahs_len ? sizeof(req->cdb) + ahs_len : 0;
+		(ahs_len ? sizeof(req->cdb) + ahs_len : 0);
 
 	task = iscsi_alloc_task(conn, task_len);
 	if (task)



More information about the stgt mailing list