[Stgt-devel] [Patch 2/8 ] Combine INQUIRY into a common spc_inquiry routine.

[Ming Zhang]

On Thu, 2007-05-24 at 08:42 +1000, Mark Harvey wrote:
> On 5/23/07, Ming Zhang <blackmagic02881 at gmail.com> wrote:
> > On Wed, 2007-05-23 at 13:01 +1000, Mark Harvey wrote:
> > > +struct physicalAttributes {
> > > +       char    scsi_id[SCSI_ID_LEN];
> > > +       char    scsi_sn[SCSI_SN_LEN];
> > > +
> > > +       /* SCSI Inquiry Params */
> > > +       char    VendorIdent[9];
> > > +       char    ProductIdent[17];
> > > +       char    ProductRev[5];
> > > +       uint16_t        version_desc1;
> > > +       uint16_t        version_desc2;
> > > +       uint16_t        version_desc3;
> > > +       uint16_t        version_desc4;
> > > +       uint16_t        version_desc5;
> > > +       uint16_t        version_desc6;
> >
> > can we make it uint16_t *version_desc, which point to a dynamically
> > allocated array with last entry as 0?
> 
> Looking back over the SPC-3 Inquiry data ( Sec 6.4.2 ), I should have
> defined this as
>                uint16_t       version_desc[8];


looks good to me.

> 
> Thanks for pointing that out...
> 
> Mark

thx u for the work.