On Wed, 7 May 2008 18:22:45 +1000 "Mark Harvey" <markh794 at gmail.com> wrote: > Hello aftab azmi, > > First off, thanks... You beat me to the punch :) It might save me some work.... > > While I can't speak authoritatively, I'm sure this will be rejected > first off due the the code base not following the Linux kernel coding > style... You can find the coding style document in the Linux kernel > source under the Documentation dir. > > I've passed it thru the scripts/checkpatch.pl script and attached are > the coding style errors: (Lots of tab/space issues) Yes, please please fix the coding style problems first. Thank for the code, Aftab and Thanks for the reviewing, Mark! |