[stgt] [PATCH 1/1] nonblocking epoll_wait loop, sched events, ISER/IB polling

[FUJITA Tomonori]

On Thu, 18 Sep 2008 18:07:08 -0400
Pete Wyckoff <pw at padd.com> wrote:

> nezhinsky at gmail.com wrote on Thu, 18 Sep 2008 21:38 +0300:
> > This patch introduces custom events scheduler, non-blocking
> > epoll_wait when events are pending, delaying IB completions
> > notifications, that leads to significant reduction in interrupts rate 
> > for iser/ib, while adding flexibility to tgtd event processing scheme.
> 
> I like the idea and am impressed by the results.  Here are some
> patch comments.
> 
> First, put all of the text in 0/1 into the changelog here.  It
> explains very well why we want this, and shows performance numbers
> to prove the worth.

Yeah, it should be here. You don't need [PATCH 0/1] mail.


> > diff --git a/usr/iscsi/iscsi_rdma.c b/usr/iscsi/iscsi_rdma.c
> > index 46e6ea8..35b0f13 100644
> > --- a/usr/iscsi/iscsi_rdma.c
> > +++ b/usr/iscsi/iscsi_rdma.c
> > @@ -144,6 +144,8 @@ struct conn_info {
> >  	/* but count so we can drain CQ on close */
> >  	int recvl_posted;
> >  
> > +        struct tgt_event tx_sched;
> > +
> 
> Tomo will not like how you use spaces instead of tabs.  You may want
> to run scripts/checkpatch.pl, as borrowed from the linux developers,
> and fixup everything it complains about.  Aspects like commas
> without space after them will also be caught by this script.

Yeah, please run scripts/checkpatch.pl and fix all the warnings before
submitting a patch.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html