[stgt] [Patch 0/15] Various bugfixes

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Fri Jun 12 04:57:36 CEST 2009


On Tue, 09 Jun 2009 18:21:26 +0200
Arne Redlich <arne.redlich at googlemail.com> wrote:

> the following patchset consists of a number of (mainly small) bugfixes
> (with the last patch being an exception both in size and in that it also
> changes TGT's behaviour, but still as part of a bugfix):

Thanks a lot!! This patchset is really great!


> 01 tgtadm: Return correct tgtadm error code and response length if
> an invalid tgtadm request was received

Applied.

> 02 iSCSI: fix use-after-free for task management requests

I have some comments.

> 03 iSCSI: fix resource leak: if passing an iSCSI task to the TGT core
> fails, the task is leaked

Applied.

> 04 Fix resource leak: SCSI mode pages are not freed on LU removal

Applied.

> 05 tgtadm: Rework tgtadm error code -> string conversion

Applied.

> 06 Fix error reporting: tgtadm expects error codes > 0, but some
> functions return error codes < 0

Applied.

> 07 tgtadm: Fix "tgtadm --debug" support

Applied.

> 08 tgtadm: zero out buffer used for tgtadm requests

Applied.

> 09 Rework tgtd startup to prevent the logging daemon from obtaining
> resources it should not have (e.g. the IPC fd) and fix
> logger daemon initialization

I have some comments.

> 10 iSCSI: send the proper StatSN in R2T PDUs

Applied.

> 11 Protect driver.h from multiple inclusion

Applied.

> 12 iSCSI: return tgtadm error codes in iscsi_target_update() and
> iscsi_target_show() for tgtadm to display human readable error
> messages

Applied.

> 13 iSCSI: return appropriate error codes for "tgtadm --op delete --mode
> conn" errors

Applied.

> 14 iSCSI: Fix Data-Out size requested with R2Ts / sent as response

I need more investigation wrt iSER.

> 15 Remove dummy RAID controller mapped by default to LUN 0

I need to think about this a bit.


Thanks,
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list