[stgt] [PATCH 1/1] Build process makeover

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Mon Oct 5 12:43:04 CEST 2009


On Mon, 5 Oct 2009 19:32:56 +0900
FUJITA Tomonori <fujita.tomonori at lab.ntt.co.jp> wrote:

> On Fri,  2 Oct 2009 08:02:25 +0200
> Florian Haas <florian.haas at linbit.com> wrote:
> 
> > A fairly thorough makeover of the build system, with one Makefile per
> > directory replacing the previous single Makefile in usr.
> > 
> > This adds some version detection magic and a "make tarball" target for
> > conveniently rolling a tarball out of a git checkout.
> > 
> > Signed-off-by: Florian Haas <florian.haas at linbit.com>
> > ---
> >  Makefile          |   78 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  conf/Makefile     |   11 +++++++
> >  conf/targets.conf |    2 +
> >  doc/Makefile      |   22 +++++++++++++++
> >  scripts/Makefile  |   13 +++++++++
> >  scripts/tgt-admin |    2 +-
> >  usr/Makefile      |   22 +-------------
> >  7 files changed, 129 insertions(+), 21 deletions(-)
> >  create mode 100644 Makefile
> >  create mode 100644 conf/Makefile
> >  create mode 100644 conf/targets.conf
> >  create mode 100644 doc/Makefile
> >  create mode 100644 scripts/Makefile
> 
> Mostly looks ok but
> 
> > +docdir = /usr/share/doc/tgt-$(VERSION)
> 
> This is different from what the current Makefile works.
> 
> The patch description tells me that this simply splits the Makefile
> (and adds some new rules like building a tar). If you want to change
> the behavior, please try with a separate patch (though I don't think
> this change makes sense).

Note that this change refers to 'docdir change'. If you send a patch
to just split the Makefile and adds some new rules (without no hidden
changes), then I'm happy to apply it.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list