Hi. I changed it to --control-port and -C regards ronnie sahlberg On Thu, Feb 25, 2010 at 7:50 PM, FUJITA Tomonori <fujita.tomonori at lab.ntt.co.jp> wrote: > On Wed, 24 Feb 2010 14:29:18 +1100 > ronnie sahlberg <ronniesahlberg at gmail.com> wrote: > >> The part of the patch where we control the management channel seems to >> have been lost/forgotten. >> >> Please find a patch attached that contains an updated version Or's >> patch for specifying the management channel >> to allow us to run multiple instances of tgtd concurrently. >> >> This can be useful in testing since on very powerful machines, the >> single thread for the eventloop reaches 100% of one core, this caps >> performance. > > adding specifying management port support is fine by me, as I said > before, I don't fancy running multiple tgtd though. > > I have two comments: > > 1. We already have long options like "initiator-address" so I like > clear long options. Something like 'management-port' or 'control-port' > instead of 'mgmt-port'? > > 2. Is it better to have the same short option for tgtd and tgtadm? > > > Thanks, > -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Based-on-Or-Gerlitz-patch-from.patch.gz Type: application/x-gzip Size: 5026 bytes Desc: not available URL: <http://lists.wpkg.org/pipermail/stgt/attachments/20100226/6ea85137/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Based-on-Or-Gerlitz-patch-from.patch Type: text/x-diff Size: 21727 bytes Desc: not available URL: <http://lists.wpkg.org/pipermail/stgt/attachments/20100226/6ea85137/attachment.patch> |