FUJITA Tomonori wrote: > The changes to target.c and isns.c looks wrong. The patch is based on > the old version? Yes, it is based on an old version. I had branched off quite a long time ago and since then merged in your latest changes only up to a certain point. When producing the patches, i only cared about making them compile after being applied to the git head. So i missed some recently added (and yet unmerged) deltas, like the "redirect" stuff etc. I did not expect to have these patches applied now. May I remind you what was their starting point: > > I propose starting with the "rectification" of iscsi text functions, by > > changing them to accept plain char * buffers, making them independent from > > iscsi structures specifics. Such semantic changes do not alter the logic > > of the existing code... > > Please send all the patches that you have now (no need to clean up > them). I just want to see the whole picture first. Please, view the "wrong" portions outside of iser.* as the "noise" that i did not clean up, and just disregard them. I guess it is much more important to agree about the direction to take with iser proper. When we get to the "real" patches, then, of course, they will be based on the latest git head. If you have questions about the mew implementation, please don't hesitate to ask. Do you want me to describe it in some detail? -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html |