On Fri, 30 Jul 2010 18:39:49 +0300 Alexander Nezhinsky <alexandern at Voltaire.COM> wrote: > FUJITA Tomonori wrote: > > With the duplication, I can just tell you that iSCSI/tcp has a bug so > > iser might have the similar one. When I understand the iser code, I > > could work on the unification. > > That's ok with me. Still, one thing that i would do before starting with > the new iser patches is: > >>>> ... the "rectification" of iscsi text functions, by > >>>> changing them to accept plain char * buffers, making them independent from > >>>> iscsi structures specifics. Such semantic changes do not alter the logic > >>>> of the existing code... > > This would make the duplicated code almost twice less and clearly will not > bother you when you change iscsi/tcp. Also, no further expert opinion is needed. > So if you "ok" it, i can send the patches for text functions only, this time > the "real" ones. You mean that you want to convert char *text_key_find(struct iscsi_connection *conn, char *searchKey) to: char *text_key_find(char *data, int datasize, char *searchKey) Right? If so, it sounds ok to me. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html |