On Wed, 16 Jun 2010 15:20:10 +0300 (IDT) Alexander Nezhinsky <alexandern at voltaire.com> wrote: > add "debug" property to --mode system; > allows to change debug mode on the fly; > two values: on/off are supported > > invocation example: > tgtadm --mode system --op update --name debug --value on > > Signed-off-by: Alexander Nezhinsky <alexandern at voltaire.com> > --- > usr/mgmt.c | 14 +++++++++++++- > usr/tgtadm.c | 22 ++++++++++++++++++++++ > 2 files changed, 35 insertions(+), 1 deletions(-) Looks a nice feature to me, however there are some style problems. I fixed them this time. But please use ./scripts/checkpatch.pl before submitting a patch next time. ERROR: need space after that ',' (ctx:VxV) #63: FILE: usr/mgmt.c:262: + if (!strncmp(mtask->buf,"debug=",6)) { ^ ERROR: need space after that ',' (ctx:VxV) #63: FILE: usr/mgmt.c:262: + if (!strncmp(mtask->buf,"debug=",6)) { ^ ERROR: need space after that ',' (ctx:VxV) #64: FILE: usr/mgmt.c:263: + if (!strncmp(mtask->buf+6,"on",2)) { ^ ERROR: need space after that ',' (ctx:VxV) #64: FILE: usr/mgmt.c:263: + if (!strncmp(mtask->buf+6,"on",2)) { ^ ERROR: need spaces around that '=' (ctx:VxV) #65: FILE: usr/mgmt.c:264: + is_debug=1; ^ ERROR: need space after that ',' (ctx:VxV) #68: FILE: usr/mgmt.c:267: + else if (!strncmp(mtask->buf+6,"off",3)) { ^ ERROR: need space after that ',' (ctx:VxV) #68: FILE: usr/mgmt.c:267: + else if (!strncmp(mtask->buf+6,"off",3)) { ^ ERROR: else should follow close brace '}' #68: FILE: usr/mgmt.c:267: + } + else if (!strncmp(mtask->buf+6,"off",3)) { ERROR: need spaces around that '=' (ctx:VxV) #69: FILE: usr/mgmt.c:268: + is_debug=0; ^ ERROR: else should follow close brace '}' #75: FILE: usr/mgmt.c:274: + } + else if (tgt_drivers[lld_no]->update) Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html |