[stgt] [PATCHes] Updated patches for thin-provisioning support

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Sat Apr 14 13:00:53 CEST 2012


On Sat, 14 Apr 2012 19:24:10 +1000
ronnie sahlberg <ronniesahlberg at gmail.com> wrote:

> On Sat, Apr 14, 2012 at 6:24 PM, FUJITA Tomonori
> <fujita.tomonori at lab.ntt.co.jp> wrote:
>> On Sun, 1 Apr 2012 08:26:27 +1000
>> ronnie sahlberg <ronniesahlberg at gmail.com> wrote:
>>
> ...
>>> +                     /* we can only punch holes aligned for full blocks.
>>> +                      * if not aligned to a block boundary we overwrite
>>> +                      * the first partial block with zero
>>> +                      */
>>
>> Where this limit comes from? seems that ext4 can handle the unaligned
>> request.
>>
> 
> BTRFS on linux 3.2
> 
> You cant punch holes smaller than the fs blocksize anyway so it is
> either replaced by "write all zero"
> in tgtd or relying on the underlying filesystem doing it for you
> instead of failing.

I don't think that the current inconsistent situation is good (some
file systems do zero-ing and some don't). I prefer file systems to
handle this.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list