[stgt] [PATCH] ISCSI: Honour MaxRecvDataSegmentLength for NORMAL sessions

[FUJITA Tomonori]

On Sat, 18 Aug 2012 18:25:41 +0900 (JST)
FUJITA Tomonori <fujita.tomonori at lab.ntt.co.jp> wrote:

> On Sat, 18 Aug 2012 19:21:27 +1000
> ronnie sahlberg <ronniesahlberg at gmail.com> wrote:
> 
>> On Sat, Aug 18, 2012 at 7:10 PM, FUJITA Tomonori
>> <fujita.tomonori at lab.ntt.co.jp> wrote:
>>> On Sat, 18 Aug 2012 18:56:09 +1000
>>> ronnie sahlberg <ronniesahlberg at gmail.com> wrote:
>>>
>>>> The bug is that IF the initiator does state it can handle larger
>>>> DATA-IN PDUs than 8kb,   like open-iscsi does, and all other iniators
>>>> also does.
>>>
>>> btw, I've seen initiators that don't send
>>> MaxRecvDataSegmentLength long ago. I can't recall what.
>>>
>>>
>>>> The b\ug in tgtd in processing the login is that tgtd ONLY parses this
>>>> "lets use bigger than 8kb pdu" IFF the session is a discovery session,
>>>> but not for NORMAL sessions.
>>>
>>> Can you recall why we handle discovery and normal sessions differently?
>>>
>> 
>> The parameter MaxRecvDataSegmentLength is meaningless for a discovery session.
> 
> Really?
> 
> The code was intentionally for discovery session:
> 
> http://www.spinics.net/lists/linux-stgt/msg00894.html

applied with the following patch:

http://www.spinics.net/lists/linux-stgt/msg00895.html
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html