[stgt] [PATCH] MMC READ TOC, asking for track 0 is valid even if track 0 does not exist

[ronnie sahlberg]

It should work fine.

Before your patch
d777dcd5cb7f102633d18b980691c718414ea9ed
we were broken and only allowed asking for "all tracks starting at track 0".
This worked most of the time since most applications only ask for "all
tracks starting at track 0".

The bug in bugzilla is for an application that asks for "all tracks
starting at track 1".
Prior to d777.    that wouldnt work, since we were broken and only
allowed "all tracks starting at 0".

d777. changed this to only allow "all tracks starting at 1", which
fixed the special application in bugzilla, but broke other things,
like
automounting of CDROMs in Ubuntu.


Since we have only one track, track#1,  my current patch should be the
correct behaviour.
Either if asking for "all tracks starting at 0"   or "all tracks starting at 1"
both cases are valid and both cases should return a single track, track #1.



regards
ronnie sahlberg




On Sat, Jan 7, 2012 at 11:21 AM, Andy Grover <agrover at redhat.com> wrote:
> On 12/25/2011 02:48 PM, ronnie sahlberg wrote:
>> List, Tomo
>>
>> Please find attached a patch for MMC.
>> Basically, if an initiator asks for "READ TOC track==0"
>> this is valid even if track 0 does not exist.
>>
>> For single session media such as TGTD emulated, track 0 does not
>> exist, only track 1 exist, but
>> asking for track 0 is still valid.
>
> Will this fix make any difference with this open bug:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=690181
>
> by any chance?
>
> Thanks -- Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html