[stgt] [PATCH 00/13] transfer len and resid count handling fixes

Or Gerlitz ogerlitz at mellanox.com
Thu Feb 7 10:31:41 CET 2013


On 07/02/2013 10:27, FUJITA Tomonori wrote:
> On Tue, 5 Feb 2013 11:32:38 +0200
> Alexander Nezhinsky <nezhinsky at gmail.com> wrote:
>
>> Hi
>>
>> It's been more than 2 weeks since i posted the patches.
>> Could you guys have a critical look on them?
> Sorry about the delay.
>
> I've just started to look at the code. I agree that the current code
> to handle various lengths is messy. However, my question is what are
> actual problems that this patchset fixes?

Hi Tomo,

These patches solved a real world interoperability problem between TGT and
the ESX initiator, as Alex describes in the commit message of patch 
number #1:

"Current iser.c implementation behaves according to the spec, but because
the SCSI layer sometimes does not, it may occasionally produce incorrect
responses. Linux initiator disregards them, but more pedantic initiators,
like VmWare's ESX, throws errors.

This patch basically forces SCSI layer to set only the actual transfer len
as described in section 2.5. and to implement residual+overflow calculations as
described in section 3. of the above algorithm entirely in the Transpor layer."

Or.

--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list