[stgt] [PATCH] Fix segfault if device_type set to pt but bstype not sg or bsg

FUJITA Tomonori fujita.tomonori at lab.ntt.co.jp
Sat Mar 22 12:57:26 CET 2014


On Tue, 18 Mar 2014 11:02:02 -0700
Andy Grover <agrover at redhat.com> wrote:

> If bstype not set to sg or bsg, it will default to rdwr, and we will
> call target_cmd_perform instead of target_cmd_perform_passthrough when
> accessing the device, which crashes tgtd. There's an existing check for
> setting bstype without setting dev_type, but also add a check the other
> way, setting dev_type without setting bstype to a valid value for pt.
> 
> Add an error message to the existing check, as well.
> 
> Signed-off-by: Andy Grover <agrover at redhat.com>
> ---
>  usr/target.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Applied, thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list