[Bug 15] New: Execute=once packages are not controlled by revision tag

[bugzilla-daemon at wpkg.org]

Please reply using this URL only: http://bugs.wpkg.org/show_bug.cgi?id=15

           Summary: Execute=once packages are not controlled by revision tag
           Product: WPKG
           Version: 0.9.3-test1
          Platform: Other
        OS/Version: FreeBSD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wpkg.js
        AssignedTo: mangoo at mch.one.pl
        ReportedBy: ai at bsdler.de
         QAContact: wpkg-users at lists.wpkg.org


Hi

When using execute=once packages (in my case I use it for updating the
spybot_includes.exe file which is the update for the spybot ruleset, so i have
to use execute=once as there is no checkcondition applicable for this) no
revision check gets done anymore. This will avoid upgrading of this package
forever. On the "silent installers" page there is also an example using this way
to run a spybot check on wpkg invocation.

Maybe there is some other way to slove this problem, as i think my problem is
that i don't have a chance to install something without adding a checkcondition
to it without using execute=once, which is not revision aware now. 

I've made a small patch to fix this for me, but maybe someone can tell me how it
is intended to upgrade not-condition-checkable packages (manually indicating
upgrade by bumping revision tag in packages.xml):

--- /home/shoki/tmp/wpkg-0.9.3-test1/wpkg.js    Mon Jan 30 10:47:53 2006
+++ /tmp/wpkg_new.js    Mon Jan 30 10:34:17 2006
@@ -590,7 +590,7 @@
             
         if (executeAttr == "once") {
             if ((null == installedPackage) |
-               ((null != installedPackage) &&
(parseInt(installedPackage.getAttribute("revision")) < packageRev )) ) {
+               (parseInt(installedPackage.getAttribute("revision")) <
packageRev ) ) {
                 try {
                     if (notifyAttr != "false") {
                         notifyUserStart();


BTW, really great tool and really great idea to use JScript for this which
allows me to enhance wpkg to fit our corporate needs. Thanks you.

-- 
Configure bugmail: http://bugs.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.