[wpkg-users] [Bug 27] WPKG should accept exit code="any"

[bugzilla-daemon at wpkg.org]

Please reply using this URL only: http://bugs.wpkg.org/show_bug.cgi?id=27





------- Additional Comments From mangoo at mch.one.pl  2006-06-22 18:10 -------
Perhaps the code should look like this:

            // search for exit code
            var exitNode = cmdNode.selectSingleNode("exit[@code='" + result +
"']" );
            var anyExitCode = cmdNode.selectSingleNode("exit[@code='any']" );

               
            // check for special exit codes
            if (exitNode != null || tomekNode != null ) {
                if (exitNode != null && exitNode.getAttribute("reboot") == "true") {
                    // this exit code forces a reboot
                    info("Command in upgrade of " + packageName + " returned " +
                        "non-zero exit code [" + result + "]. This exit code " +
                        "requires an immediate reboot.");
                    reboot();
                } else if (anyExitNode.getAttribute("code") == "any") {
                    // this exit code is ignored
                    info("Command in upgrade of " + packageName + " returned " +
                        "non-zero exit code [" + result + "]. This exit code " +
                        "is not an error (we accept any exit code).");

                } else {
                    // this exit code is successful
                    info("Command in upgrade of " + packageName + " returned " +
                        "non-zero exit code [" + result + "]. This exit code " +
                        "is not an error.");
                    continue;
                }
            }

Or perhaps we should merge "// this exit code is ignored" and "// this exit code
is successful" into one.

-- 
Configure bugmail: http://bugs.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.





_______________________________________________
wpkg-users mailing list
wpkg-users at lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users