[wpkg-users] [Bug 19] New: multiple calls to wpkg.js /install:package add more entries to wpkg.xml

bugzilla-daemon at wpkg.org bugzilla-daemon at wpkg.org
Wed Mar 1 19:24:47 CET 2006


Please reply using this URL only: http://bugs.wpkg.org/show_bug.cgi?id=19

           Summary: multiple calls to wpkg.js /install:package add more
                    entries to wpkg.xml
           Product: WPKG
           Version: 0.9.4
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wpkg.js
        AssignedTo: mangoo at mch.one.pl
        ReportedBy: stian.husemoen at batbelt.org
         QAContact: wpkg-users at lists.wpkg.org


multiple calls to "wpkg.js /install:package" adds more entries to wpkg.xml

This simple patch *seems* to solve the problem, please verify:


--- wpkg-0.9.4/wpkg.js  2006-02-27 13:15:17.000000000 +0100
+++ wpkg-0.9.4-sh/wpkg.js       2006-03-01 18:58:28.000000000 +0100
@@ -1198,19 +1198,20 @@
             throw new Error("Could not install " + packageName + ". " +
                             "Failed checking after installation.");
         }
-    }
-    
-    // append new node to local xml
-    settings.appendChild(packageNode);
-    saveXml(settings, settings_file);
+
     
-    // reboot the system if this package is suppose to
-    if (packageNode.getAttribute("reboot") == "true") {
-        info("Installation of " + packageName + " successful, system " +
-            "rebooting.");
-        reboot();
-    } else {
-        info("Installation of " + packageName + " successful.");
+       // append new node to local xml
+       settings.appendChild(packageNode);
+       saveXml(settings, settings_file);
+       
+       // reboot the system if this package is suppose to
+       if (packageNode.getAttribute("reboot") == "true") {
+         info("Installation of " + packageName + " successful, system " +
+              "rebooting.");
+         reboot();
+       } else {
+         info("Installation of " + packageName + " successful.");
+       }
     }
 }

-- 
Configure bugmail: http://bugs.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.



wpkg-users mailing list
wpkg-users at lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users




More information about the wpkg-users mailing list