[wpkg-users] [Bug 75] File version check does not work properly

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=75





--- Comment #9 from Tomasz Chmielewski <mangoo at wpkg.org>  2007-11-01 19:24:14 ---
What about:

--- wpkg.js.old 2007-10-17 21:10:51.000000000 +0200
+++ wpkg.js     2007-11-01 19:12:49.000000000 +0100
@@ -1188,6 +1188,7 @@

             CheckValFromFileSystem = GetFileVersion(checkPath);
             CheckValFromWpkg       = checkValue;
+            if (CheckValFromFileSystem == "" ) { CheckValFromFileSystem =
"UNKNOWN" }
             if (CheckValFromFileSystem != "UNKNOWN") {
                 var versionresult = VersionCompare(CheckValFromFileSystem,
                                                    CheckValFromWpkg);


or, first check:


... CheckValFromFileSystem == "" || CheckValFromFileSystem == "UNKNOWN" ...
return (false);

else

all pretty code
{ which does 
version checking }


?
Which is more sexy?


-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


wpkg-users mailing list
wpkg-users at lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users