[wpkg-users] [Bug 79] Major WPKG enhancements, remote logging, doc, internal restructuring

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=79


Rainer Meier <skybeam at users.sourceforge.net> changed:

           What    |Removed                     |Added

  Attachment #58 is|0                           |1
           obsolete|                            |




--- Comment #31 from Rainer Meier <skybeam at users.sourceforge.net>  2007-11-12 14:38:57 ---
Created an attachment (id=59)
 --> (http://bugzilla.wpkg.org/attachment.cgi?id=59)
Full package, added [ss] template, added seconds to timestamp for log file.

Change log:

 * NEW: Allow use of [ss] within logfile pattern to allow creating of
 *      independent log file even if subsequent runs within the same minute.
 * MOD: Added seconds within timestamp for logfile output.
 * MOD: Changed the template of "hours" to lowercase [hh] which more clearly
 *      seperates hour/minutes/seconds templates from year/month/day values.

I also thought about the request from Leon to include a message when WPKG is
started and when it finishes. As there is a separate file (I do not support
appending to the same file) for each run this is not needed. If anybody wants
to prepare a patch I suggest adding a "start mark" print right at the end of
the initializeLog() function where a new logfile is generated. An "end mark"
might be printed within the exit() function.

However please keep in mind that WPKG might create several log files. During
initialization (when the [PROFILES] template cannot be evaluated) there might
be logs written already. These logs go to "%TEMP%\wpkg-logInit.log". This file
should definitely not be appended since it will not be rotated (unless you add
code there as well).

Again my view is the following:
If we start to introduce things like log-archiving, housekeeping and rotation
here then everybody has some different idea of rotating the files and we end up
blowing up wpkg.js with functionality which is not its task at all. We probably
even end up implementing rotating functionality similar to already existing
scripts like logrotate.
>From my point of view allowing to create one new log file per run (which you
can du by including the seconds within the log-file template) is perfectly
fine. Most people will be even happy by having a log of the last run and are
fine with the "wpkg-[HOSTNAME].log" template while it protects them from
getting a polluted log directory.

I think we should keep wpkg.js focused on the main task(s):
- Package installation/upgrade/uninstall

It's just a matter of time unless somebody asks for functionality like "sending
e-mail on error" but introducing such code (while it is perfectly possible)
introduces the risk of troubles and failing to successfully do its main task:
Package management.
For example sending e-mail on failure can be done using a log-watcher
(watchdoc) on the server as well. So if e-mail sending fails it does not effect
the package installation at all.

So now it's getting sligthly off-topic. I introduced a log of new features now
and re-designed major parts of the script. Therefore I propose the following:

- In-depth testing of my changes (verification, fixing)
- Preparing a new public release
- Closing down this bugzilla

In particular I ask you not to publish all your wishes here within Bug 79. If
you do so then we can never release it. Please focus on the current feature
set, test it and then we release it.

After release we can open new tickets for new enhancements but remember to
focus the script on its main purpose. Please practice the KISS (Keep It Simple
And Stupid) approach. Please.


-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


wpkg-users mailing list
wpkg-users at lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users