[wpkg-users] [Bug 103] Handling absence of config.xml

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=103


Rainer Meier <r.meier at wpkg.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #99 is|0                           |1
           obsolete|                            |




--- Comment #1 from Rainer Meier <r.meier at wpkg.org>  2008-02-18 09:19:42 ---
Created an attachment (id=101)
 --> (http://bugzilla.wpkg.org/attachment.cgi?id=101)
Full package, fixed for bug 103 and 104

OK, the facts here might be a little more complicated than you might think
actually. You are right that in the current implementation nothing is printed
in case config.xml is missing. However WPKG is fully operational even
completely without config.xml.
But...
When the /quiet parameter is specified OR config.xml contains quiet=true
parameter WPKG should never ever print any line (but write to event log). When
your change is applied then WPKG will print any message logged during
initialization to the console window. Even if /quiet or the quiet parameter
within config.xml is set it will print some lines which is completely against
the intention of the /quiet parameter.

Therefore the implementation was made in such a way that WPKG always operates
in quiet mode during initialization. As soon as the real quiet mode could be
evaluated (after reading config.xml and parsing the command line parameters)
quiet mode could be switched off.

Unfortunately you're right in one thing. The /help screen does not show up if
config.xml is missing (it is logged to event log instead). I consider this to
be Bug 103.1.

Additionally WPKG yields a null-pointer exception during initialization which
is logged to event log. I consider this to be Bug 103.2.


A fix for both issues is included in the attached WPKG 1.0 RC8. The
implementation slightly differs from your proposal. Instead of handling
possible null-pointer return values on various locations I just make sure that
getConfig() does return a valid XML node in any case which fixes all
null-pointer problems at once. Now also the help screen shows up properly.

Again: I consider it to be a bad idea to disable quiet mode during
initialization because this might lead to undesired user-notifications during
initialization even if the /quiet flag and/or the quiet parameter is set.


Changes:
Change notes
============

WPKG Version: 1.0-RC8
Author:     : Rainer Meier <skybeam (at) users.sourceforge.net>
Date        : 2008-02-18

Changes/fixes visible to the user:

Summary:
- Fixed missing quote in log output

FIX: Included cosmetic fix for Bug 104 (opening quotation missing).
     This fix adds a missing opening quotation in debug output when a new
     package is added to the local settings node (after installation success).
FIX: Fixed Bug 103. /help screen is not showing up if config.xml is missing and
     null-pointer exception is thrown.


-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.