[wpkg-users] [Bug 127] wpkg not checking local wpkg.xml file for installed packages

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=127





--- Comment #4 from Mark Nienberg <mark at tippingmar.com>  2008-07-28 22:02:06 ---
(In reply to comment #1)
> Somewhere at line 2906 (WPKG 1.1.0-M6).
> 
> This will make sure that the checks are not taken from the (probably changed)
> server side version of the package, but instead from the local wpkg.xml.

I applied this patch to v1.0.2 at line 2442 and I don't think it completely
resolves the issue.  I think in pre 1.0 versions of wpkg it was sufficient to
have an entry for the package in the local wpkg.xml to consider it installed.
With this patch, the check conditions from the local package definition must be
met in order for the package to be considered installed. (If I understand the
isInstalled() function.

The difference is shown in Example 1.
If you have the following in the local xml file:
<package id="thunderbird2" name="Mozilla Thunderbird 2.0" revision="1">
<check type="uninstall" condition="exists" path="Mozilla Thunderbird
(2.0.0.14)" />

and then the user allows thunderbird to self-update, the uninstall string in
the workstation registry will change to "Mozilla Thunderbird (2.0.0.16)".  Now
the condition is no longer met and wpkg will install the old package again at
next boot, downgrading back to the older version of thunderbird.

Also, if a package is installed by wpkg (so a local package definition is added
to the local xml file) and then the user uninstalls it manually, wpkg will
reinstall it at next boot.

Is this "by design"? Maybe, but I'm pretty sure this is a departure from
pre-1.0 behavior.


-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.