http://bugzilla.wpkg.org/show_bug.cgi?id=153 Rainer Meier <r.meier at wpkg.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #2 from Rainer Meier <r.meier at wpkg.org> 2009-04-11 18:18:05 --- Actually I see the problem but I do not fully agree with the solution. From my point of view WPKG should produce correct output no matter how often I call the removePackage() function for a single package. Therefore I did some modifications to use a similar approach as for the installPackage() function. The removePackage() function now remembers which packages it already processed and in case it is processed twice it checks if the previous removal failed or not and returns the same exit status immediately. In addition I did not like the isInstalled() check approach too much because it would re-execute all checks of a package. Apart from the fact that this takes more performance than just checking if previous removes have been successful it also might yield inaccurate results in some special cases. Probably you will find the time to do some tests on my modified version: <http://wpkg.svn.sourceforge.net/viewvc/wpkg/wpkg/current-development/wpkg.js?revision=49> By the way, I've included your typo fix as well. Sorry for all these typing mistakes; I am usually concentrating on code and impacts of changes rather than correct spelling. FIX: Fixed possible errors when a package is removed twice during the same session. This could happen if a package depends on multiple other packages which are removed during a WPKG session. Fixes Bug 153. Thanks to Jason Oster. -- Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. |