[wpkg-users] [Bug 144] New: Removed packages not progressing in priority order if server change applied .

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=144

           Summary: Removed packages not progressing in priority order if
                    server change applied.
           Product: WPKG
           Version: 1.1.x-M
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: wpkg.js
        AssignedTo: mangoo at wpkg.org
        ReportedBy: k.e.jones at brighton.ac.uk
         QAContact: wpkg-users at lists.wpkg.org


Hi,

 When packages are removed they get "fixed up" with changes from the server
package definitions to allow bad setups to be overridden and allow admins to
push changes that allow successful uninstalls. This works admirably unless the
changes being made are to the priority of each package and the uninstall issues
are caused by priority.

 The packages are sorted before the synchronization occurs hence any changes to
the priority (perhaps to fix the fault) are ignored.

example;

 a has a priority of 100
 b has priority of 101

which means b installs before a.

the admin meant for a to install before b and swaps the priority values.

The current procedure processes them in the original order when it checks to
pick up those changes and still processes in the original priority order
despite the priorities being swapped. If the install succeeds the new
priorities are saved. if it doesn't error messages are generated.


 The immediate fix is to;

a) pre-check the packages for server updates
b) collect the changed items
c) sort those items with their new priority
d) apply those changes to pre-enforce the changes
e) amend the removal list
f) sort the removal list
g) process the removals as normal.

This still has drawbacks such as;

a) ignoring impact on items not marked for removal. - perhaps the server update
changes an effective dependancy?
b) random effects should priority be a key issue for the package install
success.
c) knock on effects for priority number clashes.

 I have to admit I'm not a fan of priority numbers but switching to a wholely
dependancy based model looks complex...

 Perhaps synchronizing package definitions should be a non-installing activity?

 Ho hum, patch to follow for the immediate solution.

Keefy


-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.