[wpkg-users] [Bug 187] New: Download command fails in certain circumstances

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=187

           Summary: Download command fails in certain circumstances
           Product: WPKG
           Version: 1.1.2
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: wpkg.js
        AssignedTo: mangoo at wpkg.org
        ReportedBy: subscription at kkeane.com
         QAContact: wpkg-users at lists.wpkg.org


The <download> tag fails in a number of circumstances. Two specific ones:

- The URL is an ftp: URL
- The URL leads to a redirect.

This is even though the XMPHTTP object can handle both situations.

The cause is apparently in line 5851, where only HTTP result 200 is accepted as
success. FTP downloads instead return 0 even if successful, as indicated here:
https://developer.mozilla.org/en/using_xmlhttprequest

I believe redirects also return 0, but am not sure yet.

I think a better way to detect success is to look for xmlHttp.status >= 400.

I'm not sure if this will catch all error situations, though.

-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.