[wpkg-users] FW: Test Suite Results

Stefan Pendl stefan.pendl.71 at gmail.com
Sun Jul 10 09:48:25 CEST 2011


I have investigated the following:

* test4_hosts_nodes - 10

The host definition installed is:
	<host ipaddresses=".+1" profile-id="allip-1" />

	If this should match all IPs ending in 1 this must be changed to:
		<host ipaddresses=".+1$" profile-id="allip-1" />

----

* test4_hosts_nodes - 21

The host definition additionally installed is:
	<host ipaddresses=".+1" profile-id="allip-1" />

	If this should match all IPs ending in 1 this must be changed to:
		<host ipaddresses=".+1$" profile-id="allip-1" />

----

* test4_hosts_nodes - 22

The host definition additionally installed is:
	<host name="^.+1$" profile-id="allname-1" />

This is correct, since the name attribute will also match "/ip:10.0.0.1".

----

Finally I think that the additional need to add "^" and "$" to the name attribute in some of the host definitions is caused by this
missing code line:

// Still no match is found. Try regular
// expression host name match.
var regHostNode = new RegExp("^" + xmlNodeAttrValue + "$", "i");

Which was removed between SVN revision 147 and 148 in function getHostMatches.

Reverting the changes to the hosts.xml files and adding this to the function getHostNameAttribute by default might return the legacy
behavior.

----

Still the legacy behavior seems to be not at all clear in respect to host matching due to the need to support so many cases with one
attribute.
The possibility to not have a unique match is quite high, if the expression is "spongy" (German: schwammig).

The new extended host matching seems to be more robust due to separating the attributes.

---
Stefan




More information about the wpkg-users mailing list