[wpkg-users] [Bug 184] Add an inherit attribute to package actions

[Rainer Meier]

Hi Stefan,

On 15.09.2011 19:59, Stefan Pendl wrote:
> I have the following package commands:
>
>          <install inherit="remove"/>
>          <install cmd='MsiExec.exe /passive /norestart /log
> "%TMP%\%JH_PKG_NAME%.log" /i "%JH_PKG_MSI%"' />
>
>          <upgrade inherit="install"/>
>
>          <remove cmd='MsiExec.exe /passive /norestart /log
> "%TMP%\%JH_PKG_NAME%.log" /x "%JH_PKG_MSI%"'>
>              <exit code="1605"/>
>              <exit code="1633"/>
>          </remove>

Your syntax is wrong. The attribute for inclusion is called 'include' and not 
'inherit'. Although it's probably my fault that you hit this problem. I've 
noticed that the XSD for packages was wrongly stating to use the 'inherit' 
attribute. Actually it was proposed in Bug 184 to use 'inherit' but we use 
include in other locations as well. So I want to keep some consistency.

I've fixed the XSD now.


> And get the following error message:
>
> 2011-09-15 19:51:22, DEBUG   : Install type: install
> 2011-09-15 19:51:22, DEBUG   : Fetching install commands.
> 2011-09-15 19:51:22, DEBUG   : Fetched 2 install command(s).
> 2011-09-15 19:51:22, ERROR   : Error: Command missing. Please fix the
> package. Ignoring command.

This happens since WPKG reads <install inherit="remove"/> as a "normal" command 
but as 'cmd' is missing it ignores it and reports an error.


> Seems there is one check not yet adapted to allow inheritance to work ;-)

Try 'include'.

br,
Rainer