[wpkg-users] [Bug 291] wpkg.js won't run on non-uncode is set to c04

[bugzilla-daemon at bugzilla.wpkg.org]

http://bugzilla.wpkg.org/show_bug.cgi?id=291

--- Comment #2 from Rainer Meier <r.meier at wpkg.org> ---
OK, I have set up Windows Vista Business x64 and I was able to reproduce the
issue. Somehow the OS detection fails when the langugage for
unicode-incompatible applications is set to "Chinese (traditional, Honkgong
SAR)".

I don't know yet why the WMI query fails as it does not seem to fail for many
other languages.

However I can implement a workaround detecting "unknown" host OS. As a result
WPKG on such machines would not be able to use filters based on OS string but
everything else should work as expected.

I will spend some more time to investigate whether host OS could be detected by
slightly modifying the queries perhaps.

Meanwhile a small code change in function "getHostOS()" would help:

Change
function getHostOS() {
    if (hostOs == null) {
        var strComputer = ".";
        var strQuery = "Select * from Win32_OperatingSystem";
        try {

to

function getHostOS() {
    if (hostOs == null) {
        var hostOs = "unknown";
        var strComputer = ".";
        var strQuery = "Select * from Win32_OperatingSystem";
        try {

This makes WPKG fallback to "unknown" host status rather than "null" value when
host OS string detection fails.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wpkg.org/pipermail/wpkg-users/attachments/20161018/31c47cb1/attachment.html>