[sheepdog-users] [PATCH stable-0.7 3/3] logger: add a unified log destination option and syslog support
morita.kazutaka at lab.ntt.co.jp
Wed Jan 29 09:32:55 CET 2014
At Wed, 29 Jan 2014 11:55:29 +0900,
Hitoshi Mitake wrote:
> At Tue, 28 Jan 2014 16:53:56 +0900,
> MORITA Kazutaka wrote:
> > At Tue, 28 Jan 2014 11:34:22 +0800,
> > Liu Yuan wrote:
> > >
> > > On Mon, Jan 27, 2014 at 07:54:35PM +0900, Hitoshi Mitake wrote:
> > > > This patch adds a new parameter "dst=" to the "-l" option for
> > > > specifying logging destination. Possible parameters are below:
> > > > - default: a dedicated file under sheep's directory
> > > > - syslog: standard syslog
> > > > - stdout: standard output
> > > >
> > > > In addition, this patch removes "-o" option and "-f" option, previous
> > > > options for logging with stdout and let sheep run as a foreground
> > > > process. Now it is replaced with "-l dst=stdout".
> > >
> > > I'm not suer if we should keep full backward compatibility for 0.7.x series.
> > > logger options is changed, but this is a small change, How do you think of
> > > it, Kazutaka?
> > I don't think this patch should be back-ported. IMO, protocols
> > between sheepdog and users must have a backward compatibility for the
> > stable branches.
> This backport doesn't break compatibility. Protocols aren't affected
> and command line options are preserved (only adding a new option).
Then, the commit log is completely wrong; this patch doesn't change
the "-o", "-f", and "-l" options at all, right?
This patch is quite different from the original one and doesn't looks
like a backport. Please update the commit log and send this patch as
a new one for the stable branch.
More information about the sheepdog-users