[Sheepdog] [PATCH 2/3] sheep: remove unused code in __start_recovery()

Liu Yuan namei.unix at gmail.com
Wed Aug 31 11:44:58 CEST 2011

From: Liu Yuan <tailai.ly at taobao.com>

fill_obj_list() sets rw->retry to 1 only when it
is in error case, that will result code jumping into
'fail' label. So the code will always skip the
rw->retry checking. This patch removes unused lines.

Signed-off-by: Liu Yuan <tailai.ly at taobao.com>
 sheep/store.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/sheep/store.c b/sheep/store.c
index ef991ef..f541b41 100644
--- a/sheep/store.c
+++ b/sheep/store.c
@@ -1812,9 +1812,6 @@ static void __start_recovery(struct work *work, int idx)
 		goto fail;
-	if (rw->retry)
-		goto fail;
 	snprintf(path, sizeof(path), "%s%08u/list", obj_path, epoch);
 	snprintf(tmp_path, sizeof(tmp_path), "%s%08u/list.tmp", obj_path, epoch);

More information about the sheepdog mailing list