[Sheepdog] [PATCH] Standardize error messages and tidy up remaining messages

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Thu Dec 15 10:25:58 CET 2011


At Tue, 13 Dec 2011 17:26:23 +0000,
Chris Webb wrote:
> 
> This patch includes a number of very trivial consistency and language fixes:
> 
>   - Standardize collie error messages printed to stderr to begin with a
>     initial capital like other standard unix tools and the C library.
>     (Messages written to the sheep.log are already standardized to be
>     uncapitalised.)
> 
>   - Ensure all error messages are printed to stderr not stdout.
> 
>   - Fix some awkward wording, typos and grammatical issues in the messages.
> 
>   - Arrange for all of the tabular output from different collie commands to
>     be similarly formatted and headings capitalised.
> 
>   - Spell VDI as 'VDI' not 'vdi' nor 'Vdi' in messages and comments.
> 
> Signed-off-by: Chris Webb <chris at arachsys.com>
> ---
>  collie/cluster.c         |   36 ++++++----
>  collie/collie.c          |   61 +++++++---------
>  collie/common.c          |   20 +++---
>  collie/node.c            |   16 ++---
>  collie/treeview.c        |    4 +-
>  collie/vdi.c             |  175 +++++++++++++++++++++++-----------------------
>  include/sheep.h          |    2 +-
>  include/sheepdog_proto.h |   24 +++---
>  sheep/group.c            |    6 +-
>  sheep/journal.c          |    2 +-
>  sheep/ops.c              |    4 +-
>  sheep/store.c            |    2 +-
>  sheep/vdi.c              |   14 ++--
>  13 files changed, 181 insertions(+), 185 deletions(-)

Applied.

Thanks, Chris!  This is a great work. :)

Kazutaka



More information about the sheepdog mailing list