[Sheepdog] [PATCH v4 12/12] collie: enable cluster-wide snapshot command

Liu Yuan namei.unix at gmail.com
Wed Dec 28 14:36:24 CET 2011


On 12/28/2011 09:21 PM, Christoph Hellwig wrote:

>> $collie cluster snapshot # snapshot the whole cluster
>> $collie cluster snapshot -l # list user snapshot info
>> $collie cluster snapshot -R epoch # restore to state of targeted snapshot
>>
>> For e.g. below script
>> #!/bin/bash
> 
> This whole stuff should go into doc/, including a bit more text on
> what this whole operation is useful for, and in what case you would run
> it.
> 


Okay, I'll add it to doc later.

>> +++ b/collie/cluster.c
>> @@ -15,11 +15,14 @@
>>  #include <sys/time.h>
>>  
>>  #include "collie.h"
>> +#include "../sheep/farm.h"
> 
> Please make sure all constants that collie would need go into the
> protocol header, including a sheep/farm specific header here defeats
> the abstraction barrier.
> 


Yes, I did it just for being lazy and fast prototype dev and will fix
this later.

Thanks,
Yuan



More information about the sheepdog mailing list