[Sheepdog] [PATCH 09/10] sheep: rewrite get_max_copies using get_zones_nr_from

Shevek shevek at anarres.org
Fri Apr 27 00:02:53 CEST 2012


On Fri, 2012-04-27 at 02:44 +0800, Liu Yuan wrote:
> On 04/27/2012 02:38 AM, Liu Yuan wrote:
> 
> >> Also document it and rename it to get_nr_copies_int to avoid confusion
> >> > with get_nr_copies.
> > 
> > get_nr_copies_int is misnamed I think. How about get_current_nr_copies()
> > to mean real copies we have for the case nr_zones < nr_copies?
> 
> A second thought, how about get_nr_copies_from(nodes, nr_nodes)? or
> maybe you meant 'in' instead of 'int'?

Since it is used as the limit of the iteration, it should be
get_max_nr_copies_from()

S.




More information about the sheepdog mailing list