[sheepdog] [PATCH] collie: add command 'collie vdi reset' to reset a cloned VDI

[Alexandre DERUMIER]

>>$ collie vdi rollback -s [snapshot tag/id] 
>>
>>I guess it will help much more people than just reseting a clone image 
>>to the initial state. 

I agree with that. It's more easy to implement and more clear to understand.

ceph(rbd) use same kind of usage. ( rbd snap rollback  <snaphotid> )
qemu-img use : qemu-img snapshot -a <snaphotid>.


----- Mail original ----- 

De: "MORITA Kazutaka" <morita.kazutaka at gmail.com> 
À: "levin li" <levin108 at gmail.com> 
Cc: sheepdog at lists.wpkg.org 
Envoyé: Mercredi 29 Août 2012 09:27:29 
Objet: Re: [sheepdog] [PATCH] collie: add command 'collie vdi reset' to reset a cloned VDI 

At Wed, 29 Aug 2012 15:18:12 +0800, 
levin li wrote: 
> 
> On 2012年08月29日 15:08, MORITA Kazutaka wrote: 
> > At Wed, 29 Aug 2012 13:57:57 +0800, 
> > levin li wrote: 
> >> 
> >> From: levin li <xingke.lwp at taobao.com> 
> >> 
> >> With this command, we can reset a cloned VDI to its initial state as 
> >> it's just cloned from a snapshot, the usage is simple: 
> >> 
> >> $ collie vdi reset cloned_vdi_name 
> >> 
> >> Signed-off-by: levin li <xingke.lwp at taobao.com> 
> >> --- 
> >> collie/collie.h | 1 + 
> >> collie/common.c | 35 ++++++++++++++++++++++++++++++ 
> >> collie/vdi.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 
> >> 3 files changed, 99 insertions(+), 0 deletions(-) 
> > 
> > What is the use case of this command? Isn't it enough to delete the 
> > vdi and recreate it from snapshots? 
> > 
> > Thanks, 
> > 
> > Kazutaka 
> > 
> 
> It does the same thing as we delete the VDI first and recreate it, but faster than 
> the combination of the two commands, we don't need to call lookup_vdi too many times, 
> and many operations of the VDI deletion can be saved with this command if we only 
> want to reset the VDI. 

How about generalizing the command to a rollback command like as 
follows? 

$ collie vdi rollback -s [snapshot tag/id] 

I guess it will help much more people than just reseting a clone image 
to the initial state. 

Thanks, 

Kazutaka 
-- 
sheepdog mailing list 
sheepdog at lists.wpkg.org 
http://lists.wpkg.org/mailman/listinfo/sheepdog 



-- 

-- 



	

Alexandre D e rumier 

Ingénieur Systèmes et Réseaux 


Fixe : 03 20 68 88 85 

Fax : 03 20 68 90 88 


45 Bvd du Général Leclerc 59100 Roubaix 
12 rue Marivaux 75002 Paris