[sheepdog] [RFC PATCH] sdnet: threading tx/rx process

Liu Yuan namei.unix at gmail.com
Mon Jul 16 04:23:40 CEST 2012


On 07/14/2012 03:41 PM, Christoph Hellwig wrote:
> On Fri, Jul 13, 2012 at 08:25:37PM +0800, Liu Yuan wrote:
>> On 07/13/2012 04:47 PM, Christoph Hellwig wrote:
>>> On Wed, Jul 11, 2012 at 06:11:31PM +0800, Liu Yuan wrote:
>>>> This patch also remove request throttling because we are guaranteed to process
>>>> requests as soon as it arrives and won't block any request.
>>>
>>> I don't even understand the reason for blocking_conn_list, even with
>>> epoll + O_NONBLOCK I/O we should not have to have an artifical limit
>>> like that.
>>>
>>
>> With short thread, this isn't needed at all, cause requests are never
>> blocked.
> 
> What did these requests ever get blocked on?  The only reason why
> a request goes on blocking_conn_list is because the (arbitrary) maximum
> data in flight is exceeded.

This was introduced to by Kazutaka to address OOM problem, because in
the old code, requests are very easily accumulated because of very
limited threads. For now, threads are dynamically created and we don't
have this OOM issue.

Thanks,
Yuan



More information about the sheepdog mailing list