[sheepdog] [PATCH 1/3] sheep: split object_cache_rw

Christoph Hellwig hch at infradead.org
Mon Jul 16 08:08:21 CEST 2012


On Mon, Jul 16, 2012 at 02:06:19AM -0400, Christoph Hellwig wrote:
> On Mon, Jul 16, 2012 at 02:03:42PM +0800, Liu Yuan wrote:
> > Int just reminds me of 'integer' for a first look. Would be nice to use
> > a more descriptive and unambiguous name.
> 
> Suggest a good one and I'll change it.

The other alternative would be to remove object_cache_write_int entirely
and add a helper for the entry addition, that is both callers of
object_cache_write_int get replaced by a:

	ret = write_cache_object()
	if (ret == SD_RES_SUCCESS)
		object_cache_entry_alloc_and_add()

sequence.




More information about the sheepdog mailing list