[sheepdog] [PATCH 3/5] sheep: use stored nr_copies and flags

Christoph Hellwig hch at infradead.org
Thu Jul 19 18:20:40 CEST 2012


On Thu, Jul 19, 2012 at 03:13:11PM +0800, Liu Yuan wrote:
> On 07/19/2012 03:02 PM, Christoph Hellwig wrote:
> > I really don't like these helpers as they obsfucate what's going on.
> > That's also related to trying to use switch statements handling all
> > the cases explicitly in many places in the join code.
> > 
> 
> At least we'll type much less for state check with these helpers.
> Anyway, I am okay for a patch to remove all these helpers, but before
> that, we should use them or you could cook a patch in your series to
> remove those helpers.

I'll send a patch to go after my series today.  I have several versions
of that patch but never bothered to send it.




More information about the sheepdog mailing list