[sheepdog] [PATCH] collie: cleanup callbacks of collie command when they send header only requests

Yunkai Zhang yunkai.me at gmail.com
Fri Jul 27 08:22:26 CEST 2012


On Fri, Jul 27, 2012 at 2:10 PM, Liu Yuan <namei.unix at gmail.com> wrote:
> On 07/27/2012 02:02 PM, Yunkai Zhang wrote:
>> In fact, my fist inner version return EXIT_XXX in send_light_req(),
>> but I found that EXIT_xxx code defined in exits.h, they seems not
>> appropriate for library functions (compare to exe_req()/send_req() and
>> other system calls).Library functions usually return errno instead of
>> EXIT code.
>
> Then simply return -1 for error case. I think we already use eprintf to
> print error message, it is fine for now to only return EXIT_FAILURE for
> all collie command.

Ok, I'll give v3 later.

>
> Thanks,
> Yuan



-- 
Yunkai Zhang
Work at Taobao



More information about the sheepdog mailing list