[sheepdog] [PATCH 1/3] sheep: handle epoch_log_read errors in snap_file_write

[Liu Yuan]

On 06/07/2012 04:30 PM, Christoph Hellwig wrote:

> On Thu, Jun 07, 2012 at 11:47:56AM +0800, Liu Yuan wrote:
>> On 06/07/2012 06:23 AM, Christoph Hellwig wrote:
>>
>> Applied first one, and the other need rebasing to master.
> 
> they need the "sheep: fix nr_nodes calculation in local_stat_cluster"
> fix applied first.  I really don't think merging a minimally invasive
> fix into these cleanups is a good idea.
> 


But if we already see the problem, we only need to fix it once. You
added one fix in the previous patch and then removed the lines added in
the next fix, and these two fixes happen one after another, I don't
think there is any point doing so, unless there is a huge change for
rebasing. Rebase next fix would cost you less than a minute, so I think
we'd better rebase it rather than lazy applying first one which is
removed by subsequent one.

Thanks,
Yuan