[sheepdog] [PATCH 3/3] sheep: make forward_{read, write}_obj_req() static

Liu Yuan namei.unix at gmail.com
Wed Jun 27 16:05:42 CEST 2012


From: Liu Yuan <tailai.ly at taobao.com>

We no longer call it outside gateway.c, so we'd better make it
static and prohibit it from being called outside because they
doesn't has retry support. Developers are suggested to call
exec_local_req() instead

Signed-off-by: Liu Yuan <tailai.ly at taobao.com>
---
 sheep/gateway.c    |    4 ++--
 sheep/sheep_priv.h |    2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/sheep/gateway.c b/sheep/gateway.c
index 0c0fbf6..a97b72c 100644
--- a/sheep/gateway.c
+++ b/sheep/gateway.c
@@ -20,7 +20,7 @@
  *
  * Return success if any read succeed.
  */
-int forward_read_obj_req(struct request *req)
+static int forward_read_obj_req(struct request *req)
 {
 	int i, ret = SD_RES_SUCCESS;
 	unsigned wlen, rlen;
@@ -220,7 +220,7 @@ write_info_advance(struct write_info *wi, struct sd_vnode *v,
 	wi->nr_sent++;
 }
 
-int forward_write_obj_req(struct request *req)
+static int forward_write_obj_req(struct request *req)
 {
 	int i, err_ret = SD_RES_SUCCESS, ret, local = -1;
 	unsigned wlen;
diff --git a/sheep/sheep_priv.h b/sheep/sheep_priv.h
index 90c22cc..4cd4bb7 100644
--- a/sheep/sheep_priv.h
+++ b/sheep/sheep_priv.h
@@ -254,8 +254,6 @@ int leave_cluster(void);
 void queue_cluster_request(struct request *req);
 void do_io_request(struct work *work);
 void do_gateway_request(struct work *work);
-int forward_write_obj_req(struct request *req);
-int forward_read_obj_req(struct request *req);
 
 int update_epoch_log(uint32_t epoch, struct sd_node *nodes, size_t nr_nodes);
 int log_current_epoch(void);
-- 
1.7.10.2




More information about the sheepdog mailing list