[Sheepdog] PATCH S005: Improve type safety in node_cmp calls

[Liu Yuan]

On 05/03/2012 12:41 PM, MORITA Kazutaka wrote:

> node_cmp() is also used for qsort()/bsearch(), so we cannot change its
> arguments or return value.  I think this patch looks okay if it is
> against the current git master.
> 


Okay, makes sense to me.

>> > for equality to eliminate '== 0', so I'd suggest a name as node_equal(),
>> > which returns 1 for equality.
>> > 
>> > As other commented, you'd better use git format to generate the patch
>> > and mail it as the text body.
> We should document the rule.  I've added it to Sheepdog wiki:
>   https://github.com/collie/sheepdog/wiki/Submit-a-patch


I've added 'git format-patch' and guilt to the wiki.

Thanks,
Yuan