[sheepdog] [PATCH] sheep: don't call check_request() from resume_pending_requests

levin li levin108 at gmail.com
Tue May 29 13:26:48 CEST 2012


On 05/29/2012 06:54 PM, Liu Yuan wrote:
> From: Liu Yuan <tailai.ly at taobao.com>
> 
> It seems that we can pass the scripts without this patch, I think
> this line brings much problems (nested request manipulation) than
> it sovles.
> 
> Signed-off-by: Liu Yuan <tailai.ly at taobao.com>
> ---
>  sheep/sdnet.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/sheep/sdnet.c b/sheep/sdnet.c
> index 7fcff4b..00ef634 100644
> --- a/sheep/sdnet.c
> +++ b/sheep/sdnet.c
> @@ -240,9 +240,6 @@ void resume_pending_requests(void)
>  
>  	list_for_each_entry_safe(req, n, &pending_list, request_list) {
>  		list_del(&req->request_list);
> -
> -		if (check_request(req) < 0)
> -			continue;
>  		list_add_tail(&req->request_list, &sys->request_queue);
>  	}
>  

If without check_request(), we can just use list_splice_tail_init() instead
to make cleaner.

thanks,

levin



More information about the sheepdog mailing list