[sheepdog] [PATCH 5/7] sheep: split io_op_done

Liu Yuan namei.unix at gmail.com
Thu May 31 15:17:17 CEST 2012


On 05/31/2012 05:48 PM, Christoph Hellwig wrote:

> @@ -126,25 +146,18 @@ static void io_op_done(struct work *work)
>  	case SD_RES_NETWORK_ERROR:
>  	case SD_RES_WAIT_FOR_JOIN:
>  	case SD_RES_WAIT_FOR_FORMAT:
> -		if (!(req->rq.flags & SD_FLAG_CMD_IO_LOCAL)) {
> -			if (req->rp.epoch > sys->epoch &&
> -			    req->rp.result == SD_RES_OLD_NODE_VER) {
> -				list_add_tail(&req->request_list,
> -						&sys->wait_rw_queue);
> -			} else
> -				goto retry;
> +		if (req->rp.epoch > sys->epoch &&
> +		    req->rp.result == SD_RES_OLD_NODE_VER) {
> +			list_add_tail(&req->request_list,
> +					&sys->wait_rw_queue);


indention problem.

> +		} else {
> +			goto retry;
>  		}
> -		break;


well, I don't check the logic yet, deleting this break is intentional?
If so, need to comment /* pass through */

Thanks,
Yuan



More information about the sheepdog mailing list