[sheepdog] [PATCH] sheep: fix local_get_node_list before the node joined a cluster

Liu Yuan namei.unix at gmail.com
Thu May 31 17:12:03 CEST 2012


On 05/31/2012 11:04 PM, Christoph Hellwig wrote:

> The GET_NODE_LIST command has the force flag and thus can be executed
> before the cluster has started, which includes the short time before
> the sheep even has any node list, in which we can trigger the assert
> for current_vnode_info in get_vnode_info.


I think it is more a operation, move it outside ops.c dosen't make code
cleaner.

How about set .force = 0 for SD_OP_GET_NODE_LIST. I don't see any
benefit to run it as a force operation.

Thanks,
Yuan



More information about the sheepdog mailing list