[sheepdog] [PATCH v3 1/2] sheep: introduce journal file to boost IO performance

MORITA Kazutaka morita.kazutaka at lab.ntt.co.jp
Tue Nov 13 10:10:04 CET 2012


At Mon, 12 Nov 2012 14:09:31 +0800,
Liu Yuan wrote:
> 
> On 11/12/2012 01:08 PM, Liu Yuan wrote:
> > +static bool journal_descriptor_valid(struct journal_descriptor *jd)
> > +{
> > +	if (jd->magic != JOURNAL_DESC_MAGIC)
> > +		return false;
> > +	if (jd->oid == 0)
> > +		return false;
> 
> Well, can OID be 0? I'm not quit sure about this.

Probably, no.  I think we can safely remove it.

Thanks,

Kazutaka



More information about the sheepdog mailing list