[sheepdog] [PATCH 1/4] sheep: don't send unnecessary data against read requests

Liu Yuan namei.unix at gmail.com
Mon Sep 10 12:11:37 CEST 2012


On 09/10/2012 05:54 PM, MORITA Kazutaka wrote:
> I've also tried it, but it couldn't work.  A SD_OP_STAT_CLUSTER
> request needs to receive epoch data even when the result is not
> SD_RES_SUCCESS.  Although This patch looks a bit complicated, we
> should explicitly specify the length of response data when the request
> type is not SD_FLAG_CMD_WRITE, I think.

This will post rather burden to programmers and I guess in the future
many people will be likely repeating to forget this kind of assignment.

I am not sure if we can modify STAT_CLUSTER to adopt to our expected
changes. If not, we at least should provide one helper function to do
the finale work of the failure request instead of manual hard-code.

Thanks,
Yuan



More information about the sheepdog mailing list